feat(plugin-copy-code): add inlineSelector option #416
+99
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mister-Hope
requested review from
Copilot and
pengzhanbo
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR adds an inlineSelector option to the copy code plugin so that inline code content can be copied with a double click. It also refactors the ignoreSelector option to allow for a single selector string and updates both the plugin implementation and documentation accordingly.
- Updated options definitions (ignoreSelector and inline)
- Modified plugin configuration to handle inline copying and selector type changes
- Revised composable usage and documentation in both English and Chinese
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/features/plugin-copy-code/src/node/options.ts | Updated option types and added the inline option for specifying selectors or enabling inline copying |
| plugins/features/plugin-copy-code/src/node/copyCodePlugin.ts | Adjusted configuration for selectors including inline code and modified the inline selector logic |
| plugins/features/plugin-copy-code/src/client/composables/useCopyCode.ts | Changed the selector type and added inlineSelector handling via a double-click event listener |
| docs/zh/plugins/features/copy-code.md | Updated documentation to include details about the inlineSelector option (Chinese) |
| docs/plugins/features/copy-code.md | Updated documentation to include details about the inlineSelector option (English) |
Comments suppressed due to low confidence (1)
plugins/features/plugin-copy-code/src/node/copyCodePlugin.ts:34
- [nitpick] Consider refactoring the nested ternary for CC_INLINE_SELECTOR for better readability. For instance, using an explicit check for a boolean value (e.g., options.inline === true) could improve clarity.
: options.inline
? '[vp-content] :not(pre) > code'
: ''
Pull Request Test Coverage Report for Build 14134103214Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.